Skip to content

feat: reduce simplification tolerance - #567

Merged
tombrooks248 merged 2 commits into
mainfrom
feat/reduce-simplification-tolerance
Jun 22, 2026
Merged

feat: reduce simplification tolerance#567
tombrooks248 merged 2 commits into
mainfrom
feat/reduce-simplification-tolerance

Conversation

@tombrooks248

@tombrooks248 tombrooks248 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

So we are reducing the amount of simplification done to complex geometries when they are transformed as part of our pipelines.

Also pinning duckdb version because it looks like a more recent version was causing a test to fail, and I want to fix that in a separate PR - well at some point we should spend some time thinking about upgrading to everything to work on more recent python versions.

Why

This will make them more accurate and with less likely to incorrectly show overlaps with neighbouring geometries.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

I have done lots of testing to ensure this won't dramatically increase the processing time or API response times.

Full details can be found on this issue.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@tombrooks248
tombrooks248 force-pushed the feat/reduce-simplification-tolerance branch from 200b0b3 to 05f6c42 Compare June 17, 2026 15:06
@tombrooks248 tombrooks248 changed the title feat: reduce simplifation tolerance feat: reduce simplification tolerance Jun 17, 2026
@tombrooks248
tombrooks248 merged commit 68a9d8e into main Jun 22, 2026
5 checks passed
@tombrooks248
tombrooks248 deleted the feat/reduce-simplification-tolerance branch June 22, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants