feat: reduce simplification tolerance - #567
Merged
Merged
Conversation
tombrooks248
force-pushed
the
feat/reduce-simplification-tolerance
branch
from
June 17, 2026 15:06
200b0b3 to
05f6c42
Compare
sianteesdale
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
So we are reducing the amount of simplification done to complex geometries when they are transformed as part of our pipelines.
Also pinning duckdb version because it looks like a more recent version was causing a test to fail, and I want to fix that in a separate PR - well at some point we should spend some time thinking about upgrading to everything to work on more recent python versions.
Why
This will make them more accurate and with less likely to incorrectly show overlaps with neighbouring geometries.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
I have done lots of testing to ensure this won't dramatically increase the processing time or API response times.
Full details can be found on this issue.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?